# An example of elm-review cleanup

**URL:** <https://discourse.elm-lang.org/t/an-example-of-elm-review-cleanup/8819>\
**Category:** Show and Tell\
**Created:** [December 13, 2022, 10:35pm UTC](https://discourse.elm-lang.org/t/an-example-of-elm-review-cleanup/8819 "2022-12-13T22:35:23Z")\
**Posts on this page:** 5\
**Page:** 1

<div class="post-metadata">

**Author:** ![cbrake](https://yyz1.discourse-cdn.com/flex035/user_avatar/discourse.elm-lang.org/cbrake/32/438_2.png) [@cbrake](https://discourse.elm-lang.org/u/cbrake)\
**Post date:** [December 13, 2022, 10:35pm UTC](https://discourse.elm-lang.org/t/an-example-of-elm-review-cleanup/8819/1 "2022-12-13T22:35:23Z")

</div>

This is an example of what elm-review can do for your codebase – most of the cleanup was automatic. And the beauty of Elm is everything still just works.

> <https://github.com/simpleiot/simpleiot/pull/470>

---

<div class="post-metadata">

**Author:** ![rupert](https://yyz1.discourse-cdn.com/flex035/user_avatar/discourse.elm-lang.org/rupert/32/1775_2.png) [@rupert](https://discourse.elm-lang.org/u/rupert)\
**Post date:** [December 14, 2022, 9:47am UTC](https://discourse.elm-lang.org/t/an-example-of-elm-review-cleanup/8819/2 "2022-12-14T09:47:51Z")

</div>

How come its +2241 and -1382, I am sort of expecting that a big clean up like that is more likely to remove more lines than it added?

---

<div class="post-metadata">

**Author:** ![ream88](https://yyz1.discourse-cdn.com/flex035/user_avatar/discourse.elm-lang.org/ream88/32/1189_2.png) [@ream88](https://discourse.elm-lang.org/u/ream88)\
**Post date:** [December 14, 2022, 12:19pm UTC](https://discourse.elm-lang.org/t/an-example-of-elm-review-cleanup/8819/3 "2022-12-14T12:19:47Z")

</div>

Changes to `package-lock.json` 😖

---

<div class="post-metadata">

**Author:** ![cbrake](https://yyz1.discourse-cdn.com/flex035/user_avatar/discourse.elm-lang.org/cbrake/32/438_2.png) [@cbrake](https://discourse.elm-lang.org/u/cbrake)\
**Post date:** [December 14, 2022, 4:37pm UTC](https://discourse.elm-lang.org/t/an-example-of-elm-review-cleanup/8819/4 "2022-12-14T16:37:58Z")

</div>

@rupert good point on the lines:

Here is the commit with the automated cleanup `--fix-all`:

> <https://github.com/simpleiot/simpleiot/commit/9f2c0f5f8ef98fb1d78fae350252dcca8862e886>

so it does show a lot of lines deleted.

@ream88 thanks, package-lock.json – is a huge change.

---

<div class="post-metadata">

**Author:** ![system](https://canada1.discourse-cdn.com/flex035/uploads/elm_lang/original/1X/50a05e53677a2c3b47776d7abd0f113eb50193a1.png) [@system](https://discourse.elm-lang.org/u/system)\
**Post date:** [December 24, 2022, 4:38pm UTC](https://discourse.elm-lang.org/t/an-example-of-elm-review-cleanup/8819/5 "2022-12-24T16:38:34Z")

</div>

This topic was automatically closed 10 days after the last reply. New replies are no longer allowed.