API suggestion for dict/set in core; custom compare functions

[opvasger]

Sorry I missed the fact that you had tied specification of the comparison function to construction. I’ll blame insufficient caffeine.

Haha, no worries

But you do then have a runtime exception issue when comparing dictionaries or sets for equality because those will now contain a reference to the comparison function and comparing two non-identical functions in Elm generates a runtime exception. In other words: Dict.empty comparison1 == Dict.empty comparison2 could throw a runtime exception.

I missed this part - I can’t think of any way around function comparison here hmm…

[mattpiz]

I missed this part - I can’t think of any way around function comparison here hmm…

You could provide you own equality function like MyDict.equal, but no guaranty that users are not going to do dict1 == dict2. Except if elm compiler detect function equality attempts one day